Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52208015
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -262,13 +266,16 @@
:task->component (:task->component worker)
:stream->component->grouper (outbound-components worker-context
component-id storm-conf)
:report-error (throttled-report-error-fn <>)
- :report-error-and-die (fn [error]
- ((:report-error <>) error)
- (if (or
- (exception-cause? InterruptedException
error)
- (exception-cause?
java.io.InterruptedIOException error))
- (log-message "Got interrupted excpetion
shutting thread down...")
- ((:suicide-fn <>))))
+ :report-error-and-die (reify
+ Thread$UncaughtExceptionHandler
+ (uncaughtException [this _ error]
+ (fn [error]
--- End diff --
uncaughtException returns a void, so this function we are creating is
thrown away, and never called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
