Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1074#discussion_r52209160
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
    @@ -262,13 +266,16 @@
          :task->component (:task->component worker)
          :stream->component->grouper (outbound-components worker-context 
component-id storm-conf)
          :report-error (throttled-report-error-fn <>)
    -     :report-error-and-die (fn [error]
    -                             ((:report-error <>) error)
    -                             (if (or
    -                                    (exception-cause? InterruptedException 
error)
    -                                    (exception-cause? 
java.io.InterruptedIOException error))
    -                               (log-message "Got interrupted excpetion 
shutting thread down...")
    -                               ((:suicide-fn <>))))
    +     :report-error-and-die (reify
    +                             Thread$UncaughtExceptionHandler
    +                             (uncaughtException [this _ error]
    +                               (fn [error]
    --- End diff --
    
    Good catch. Fixing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to