Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1074#discussion_r52215061
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
    @@ -98,10 +104,25 @@ public static long currentTimeMillis() {
                 return System.currentTimeMillis();
             }
         }
    -    
    +
    +    public static long toMillis (int secs) {
    --- End diff --
    
    This is not obvious that it takes seconds.  Can we rename this as 
sesToMillis?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to