[
https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183891#comment-15183891
]
ASF GitHub Bot commented on STORM-1269:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55285470
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -536,17 +536,17 @@
(throw (RuntimeException. (str "Fatal
error, mismatched task ids: " task-id " " stored-task-id))))
(let [time-delta (if start-time-ms
(Time/deltaMs start-time-ms))]
(condp = stream-id
- ACKER-ACK-STREAM-ID (ack-spout-msg
executor-data (get task-datas task-id)
+ StormCommon/ACKER_ACK_STREAM_ID
(ack-spout-msg executor-data (get task-datas task-id)
spout-id tuple-finished-info time-delta id)
- ACKER-FAIL-STREAM-ID (fail-spout-msg
executor-data (get task-datas task-id)
+ StormCommon/ACKER_FAIL_STREAM_ID
(fail-spout-msg executor-data (get task-datas task-id)
spout-id tuple-finished-info time-delta "FAIL-STREAM" id)
)))
;; TODO: on failure, emit tuple to failure
stream
))))
receive-queue (:receive-queue executor-data)
event-handler (mk-task-receiver executor-data tuple-action-fn)
- has-ackers? (has-ackers? storm-conf)
- has-eventloggers? (has-eventloggers? storm-conf)
+ has-ackers? (clojurify-structure (StormCommon/hasAckers
storm-conf))
+ has-eventloggers? (clojurify-structure
(StormCommon/hasEventLoggers storm-conf))
--- End diff --
I don't think these should need the `clojurify-structure` calls. Were you
seeing errors without it?
> port backtype.storm.daemon.common to java
> -----------------------------------------
>
> Key: STORM-1269
> URL: https://issues.apache.org/jira/browse/STORM-1269
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> Common utils shared by the daemons (Some things should just use the Thrift
> object)
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster/Common.java
> is similar but not exactly the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
