[ 
https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183898#comment-15183898
 ] 

ASF GitHub Bot commented on STORM-1269:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1185#discussion_r55285995
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
    @@ -254,6 +254,9 @@
             (log-error e "Error when processing event")
             (Utils/exitProcess 20 "Error when processing an event")))))
     
    +(defn executor->tasks [executor-id]
    +  clojurify-structure (StormCommon/executorIdToTasks executor-id))
    --- End diff --
    
    Either we need to actually call `clojurify-structure` or we need to remove 
it.


> port backtype.storm.daemon.common to java
> -----------------------------------------
>
>                 Key: STORM-1269
>                 URL: https://issues.apache.org/jira/browse/STORM-1269
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Basti Liu
>              Labels: java-migration, jstorm-merger
>
> Common utils shared by the daemons (Some things should just use the Thrift 
> object)
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster/Common.java
>  is similar but not exactly the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to