[
https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186812#comment-15186812
]
ASF GitHub Bot commented on STORM-1269:
---------------------------------------
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55489803
--- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj ---
@@ -86,26 +40,6 @@
(defn new-executor-stats []
(ExecutorStats. 0 0 0 0 0))
--- End diff --
Yes, I recommend to just use the thrift classes directly when we work on
relative modules. It can save much effort now for the converting between
clojure and jave. Please refer to my comments at the beginning of this PR.
> port backtype.storm.daemon.common to java
> -----------------------------------------
>
> Key: STORM-1269
> URL: https://issues.apache.org/jira/browse/STORM-1269
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> Common utils shared by the daemons (Some things should just use the Thrift
> object)
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster/Common.java
> is similar but not exactly the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
