[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187616#comment-15187616 ]
ASF GitHub Bot commented on STORM-1269: --------------------------------------- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55566050 --- Diff: storm-core/test/jvm/org/apache/storm/utils/staticmocking/CommonInstaller.java --- @@ -0,0 +1,38 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version + * 2.0 (the "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm.utils.staticmocking; + +import org.apache.storm.daemon.StormCommon; + +public class CommonInstaller implements AutoCloseable { --- End diff -- I just thought that we didn't need both. We could update the tests to use StormCommonInstaller and remove this. > port backtype.storm.daemon.common to java > ----------------------------------------- > > Key: STORM-1269 > URL: https://issues.apache.org/jira/browse/STORM-1269 > Project: Apache Storm > Issue Type: New Feature > Components: storm-core > Reporter: Robert Joseph Evans > Assignee: Basti Liu > Labels: java-migration, jstorm-merger > > Common utils shared by the daemons (Some things should just use the Thrift > object) > https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster/Common.java > is similar but not exactly the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)