[
https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187621#comment-15187621
]
ASF GitHub Bot commented on STORM-1269:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-194443713
The code looks really good an I am +1 for merging it in as is. There are
still a few nits though. one with CommonInstaller and another that
@arunmahadevan pointed out for SystemTopologyBuilder that we need to come to a
resolution on.
Also you need to upmerge the drpc changes that went in have caused a minor
conflict.
> port backtype.storm.daemon.common to java
> -----------------------------------------
>
> Key: STORM-1269
> URL: https://issues.apache.org/jira/browse/STORM-1269
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> Common utils shared by the daemons (Some things should just use the Thrift
> object)
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster/Common.java
> is similar but not exactly the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
