[ 
https://issues.apache.org/jira/browse/STORM-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203703#comment-15203703
 ] 

ASF GitHub Bot commented on STORM-1625:
---------------------------------------

Github user abhishekagarwal87 commented on the pull request:

    https://github.com/apache/storm/pull/1239#issuecomment-199120735
  
    @haohui Those jars will be present in external/sql/storm-sql-core directory 
and they get added automatically when `storm sql` is run. Below is a sample 
run. Let me know if you see any jar missing
    
    ```
     /tmp/apache-storm-2.0.0-SNAPSHOT/bin/storm sql abc abc.sql 
    
    Running: 
/Library/Java/JavaVirtualMachines/jdk1.8.0_51.jdk/Contents/Home/bin/java 
-client -Ddaemon.name= -Dstorm.options= 
-Dstorm.home=/private/tmp/apache-storm-2.0.0-SNAPSHOT 
-Dstorm.log.dir=/private/tmp/apache-storm-2.0.0-SNAPSHOT/logs 
-Djava.library.path=/usr/local/lib:/opt/local/lib:/usr/lib -Dstorm.conf.file= 
-cp 
/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/asm-4.0.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/clojure-1.7.0.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/disruptor-3.3.2.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/kryo-2.21.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/log4j-api-2.1.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/log4j-core-2.1.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/log4j-over-slf4j-1.6.6.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/log4j-slf4j-impl-2.1.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/minlog-1.2.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/reflectasm-1.07-shaded.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/servlet-api-2.5.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/slf4j-api-1.7.7.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/storm-core-2.0.0-SNAPSHOT.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/lib/storm-rename-hack-2.0.0-SNAPSHOT.jar:/tmp/apache-storm-2.0.0-SNAPSHOT/conf:/private/tmp/apache-storm-2.0.0-SNAPSHOT/bin:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/calcite-avatica-1.4.0-incubating.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/calcite-core-1.4.0-incubating.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/calcite-linq4j-1.4.0-incubating.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/commons-lang-2.5.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/eigenbase-properties-1.1.5.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/guava-16.0.1.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/jackson-annotations-2.6.3.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/jackson-core-2.6.3.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/jackson-databind-2.6.3.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-core/storm-sql-core-2.0.0-SNAPSHOT.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-runtime/storm-sql-runtime-2.0.0-SNAPSHOT-tests.jar:/private/tmp/apache-storm-2.0.0-SNAPSHOT/external/sql/storm-sql-runtime/storm-sql-runtime-2.0.0-SNAPSHOT.jar
 org.apache.storm.sql.StormSqlRunner abc abc.sql
    ```


> Move storm-sql dependencies out of lib folder
> ---------------------------------------------
>
>                 Key: STORM-1625
>                 URL: https://issues.apache.org/jira/browse/STORM-1625
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core, storm-sql
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>
> We shade guava classes inside storm-core so that client can work with any 
> version of guava without any clashes. However, storm-sql-core has a 
> transitive dependency on guava and thus the guava jar is still getting 
> shipped in lib folder. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to