[
https://issues.apache.org/jira/browse/STORM-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207201#comment-15207201
]
ASF GitHub Bot commented on STORM-1625:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1239#issuecomment-200002535
I don't think that it is actually a fat jar, but I have not run the code so
I don't really know for sure.
Everything in the JAR comes from the `CompilingClassLoader.getClasses()`
https://github.com/apache/storm/blob/d839d1bf88b855edda344fc548f0701e2a018655/external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/StormSqlImpl.java#L126-L139
Inside CompilingClassLoader the value returned by getClasses is only
set/added to by the InMemoryFileManager
https://github.com/apache/storm/blob/d839d1bf88b855edda344fc548f0701e2a018655/external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/javac/CompilingClassLoader.java#L184-L201
When it is writing out the compiled .class files. I don't think it is
pulling in anything else from the classpath, unless javac somehow has the
ability to create a fat jar. Which even if that were the case, I don't see
anything like that being set in the options passed into javac
https://github.com/apache/storm/blob/d839d1bf88b855edda344fc548f0701e2a018655/external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/javac/CompilingClassLoader.java#L141-L168
> Move storm-sql dependencies out of lib folder
> ---------------------------------------------
>
> Key: STORM-1625
> URL: https://issues.apache.org/jira/browse/STORM-1625
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core, storm-sql
> Reporter: Abhishek Agarwal
> Assignee: Abhishek Agarwal
>
> We shade guava classes inside storm-core so that client can work with any
> version of guava without any clashes. However, storm-sql-core has a
> transitive dependency on guava and thus the guava jar is still getting
> shipped in lib folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
