[ 
https://issues.apache.org/jira/browse/STORM-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205928#comment-15205928
 ] 

ASF GitHub Bot commented on STORM-1625:
---------------------------------------

Github user abhishekagarwal87 commented on the pull request:

    https://github.com/apache/storm/pull/1239#issuecomment-199670230
  
    @arunmahadevan storm-kafka is needed only when kafka source is used in the 
sql. As per the documentation, one approach user can take is to put the 
additional jars in the extlib and then run the sql. Basically storm-kafka 
jar/dependencies are application dependencies which are to be added by user 
manually in classpath. 
    There are three categories of jar -
    1. storm-core dependencies - under lib - added by storm command line
    2. storm-sql-core/runtime dependencies - under 
external/sql/storm-sql-core/runtime (add by `storm sql` command)
    3. application level dependencies - To be added in classpath by user - 
storm-kafka jar falls under this category. 



> Move storm-sql dependencies out of lib folder
> ---------------------------------------------
>
>                 Key: STORM-1625
>                 URL: https://issues.apache.org/jira/browse/STORM-1625
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core, storm-sql
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>
> We shade guava classes inside storm-core so that client can work with any 
> version of guava without any clashes. However, storm-sql-core has a 
> transitive dependency on guava and thus the guava jar is still getting 
> shipped in lib folder. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to