[
https://issues.apache.org/jira/browse/STORM-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346841#comment-15346841
]
ASF GitHub Bot commented on STORM-1929:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68279943
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -113,6 +113,15 @@ public StormTopology createTopology() {
Map<String, Bolt> boltSpecs = new HashMap<>();
Map<String, SpoutSpec> spoutSpecs = new HashMap<>();
maybeAddCheckpointSpout();
+
+ if (_spouts.size() == 0) {
+ throw new IllegalArgumentException("Spouts is not set");
+ }
+
+ if (_bolts.size() == 0) {
--- End diff --
We have topologies that only have spouts (no bolts). I know it is kind of
an odd corner case where someone is just reading from an input and writing to
an output in one shot, but it is something that we have.
> Check when create topology
> --------------------------
>
> Key: STORM-1929
> URL: https://issues.apache.org/jira/browse/STORM-1929
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.0.0, 1.0.1
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> Add some check when create topology .
> 1. Spout and Bolt id shouldn't conflict
> 2. createTopology's spout and bolt set shouldn't empty .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
