[
https://issues.apache.org/jira/browse/STORM-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346843#comment-15346843
]
ASF GitHub Bot commented on STORM-1929:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68280266
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -339,8 +353,13 @@ public SpoutDeclarer setSpout(String id, IRichSpout
spout) throws IllegalArgumen
public SpoutDeclarer setSpout(String id, IRichSpout spout, Number
parallelism_hint) throws IllegalArgumentException {
validateUnusedId(id);
initCommon(id, spout, parallelism_hint);
- _spouts.put(id, spout);
- return new SpoutGetter(id);
+
+ if (_spouts.containsKey(id)) {
+ throw new IllegalArgumentException("Spout " + id + " have
existed");
--- End diff --
Similar here `"duplicate spout id found " + id`
> Check when create topology
> --------------------------
>
> Key: STORM-1929
> URL: https://issues.apache.org/jira/browse/STORM-1929
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.0.0, 1.0.1
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> Add some check when create topology .
> 1. Spout and Bolt id shouldn't conflict
> 2. createTopology's spout and bolt set shouldn't empty .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
