[
https://issues.apache.org/jira/browse/STORM-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347589#comment-15347589
]
ASF GitHub Bot commented on STORM-1929:
---------------------------------------
Github user darionyaphet commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68347350
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -113,6 +113,15 @@ public StormTopology createTopology() {
Map<String, Bolt> boltSpecs = new HashMap<>();
Map<String, SpoutSpec> spoutSpecs = new HashMap<>();
maybeAddCheckpointSpout();
+
+ if (_spouts.size() == 0) {
+ throw new IllegalArgumentException("Spouts is not set");
+ }
+
+ if (_bolts.size() == 0) {
--- End diff --
only have spout and don't have bolt is a strange use case . In my mine
spout should just read message into topology , any other operation should move
into bolts .
I have remove the check of `_bolts.size()` .
> Check when create topology
> --------------------------
>
> Key: STORM-1929
> URL: https://issues.apache.org/jira/browse/STORM-1929
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.0.0, 1.0.1
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> Add some check when create topology .
> 1. Spout and Bolt id shouldn't conflict
> 2. createTopology's spout and bolt set shouldn't empty .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
