[
https://issues.apache.org/jira/browse/STORM-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348474#comment-15348474
]
ASF GitHub Bot commented on STORM-1886:
---------------------------------------
Github user kosii commented on the issue:
https://github.com/apache/storm/pull/1470
A short list of modifications
- I went for the `Optional` class. Using your idea largely simplified the
code.
- delete now returns the current value
- I didn't use a different set to store `pendingPrepare`, the deleted keys
are represented with tombstones in the redis hash
> Extend KeyValueState interface with delete method
> -------------------------------------------------
>
> Key: STORM-1886
> URL: https://issues.apache.org/jira/browse/STORM-1886
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Balazs Kossovics
>
> Even if the implementation of checkpointing only uses the get/put methods of
> the KeyValueState interface, the existance of a delete method could be really
> useful in the general case.
> I made a first implementation, what do you think about?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
