Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r79576337
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -479,16 +482,17 @@ public OffsetAndMetadata findNextCommitOffset() {
KafkaSpoutMessageId nextCommitMsg = null; // this is a
convenience variable to make it faster to create OffsetAndMetadata
for (KafkaSpoutMessageId currAckedMsg : ackedMsgs) { //
complexity is that of a linear scan on a TreeMap
- if ((currOffset = currAckedMsg.offset()) ==
initialFetchOffset || currOffset == nextCommitOffset + 1) { // found
the next offset to commit
+ if ((currOffset = currAckedMsg.offset()) ==
nextCommitOffset + 1) { // found the next offset to commit
--- End diff --
With this change is the code going to work for a topic that does not yet
have any records and/or commits in it?
I recall testing the condition using initialFetchOffset was necessary. Why
isn't it necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
