Github user jfenc91 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1679#discussion_r79657089
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -451,11 +454,11 @@ public int compare(KafkaSpoutMessageId m1, 
KafkaSpoutMessageId m2) {
         /**
          * This class is not thread safe
          */
    -    private class OffsetEntry {
    +    class OffsetEntry {
             private final TopicPartition tp;
             private final long initialFetchOffset;  /* First offset to be 
fetched. It is either set to the beginning, end, or to the first uncommitted 
offset.
                                                      * Initial value depends 
on offset strategy. See KafkaSpoutConsumerRebalanceListener */
    -        private long committedOffset;     // last offset committed to 
Kafka. Initially it is set to fetchOffset - 1
    +        long committedOffset;     // last offset committed to Kafka. 
Initially it is set to fetchOffset - 1
    --- End diff --
    
    Unless there is a way I don't know about, using reflection is hard to 
follow and difficult to refactor making it somewhat fragile. I am adding a 
protected get method and changing this back to private to hopefully address 
your concerns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to