Github user hmcl commented on a diff in the pull request:
    --- Diff: 
    @@ -479,16 +487,17 @@ public OffsetAndMetadata findNextCommitOffset() {
                 KafkaSpoutMessageId nextCommitMsg = null;     // this is a 
convenience variable to make it faster to create OffsetAndMetadata
                 for (KafkaSpoutMessageId currAckedMsg : ackedMsgs) {  // 
complexity is that of a linear scan on a TreeMap
    -                if ((currOffset = currAckedMsg.offset()) == 
initialFetchOffset || currOffset == nextCommitOffset + 1) {            // found 
the next offset to commit
    +                if ((currOffset = currAckedMsg.offset()) == 
nextCommitOffset + 1) {            // found the next offset to commit
                         found = true;
                         nextCommitMsg = currAckedMsg;
                         nextCommitOffset = currOffset;
                     } else if (currAckedMsg.offset() > nextCommitOffset + 1) { 
   // offset found is not continuous to the offsets listed to go in the next 
commit, so stop search
                         LOG.debug("topic-partition [{}] has non-continuous 
offset [{}]. It will be processed in a subsequent batch.", tp, currOffset);
                     } else {
    -                    LOG.debug("topic-partition [{}] has unexpected offset 
[{}].", tp, currOffset);
    -                    break;
    +                    //Received a redundant ack. Ignore and continue 
    --- End diff --
    Do you have a test case where we can reproduce this consistently? This code 
is already  running in a large production environment, and according to the 
feedback I received, there are no issues of this nature. 
    I am also a bit confused on what I mean by multiple acks. I am pretty sure 
storm guarantees that a tuple it's either acked (once), failed (once), or times 
out (which is equivalent to failing)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to