Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1724#discussion_r82612830
  
    --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
    @@ -485,14 +482,14 @@ int setup_stormdist_dir(const char* local_dir) {
     
           case FTS_DP:        // A directory being visited in post-order
           case FTS_DOT:       // A dot directory
    +      case FTS_SL:        // A symbolic link
    +      case FTS_SLNONE:    // A broken symbolic link
    --- End diff --
    
    I'm also not sure why we want the symlink/a broken symlink to be a noop?  
We use lchown to not follow the symlink, so we will be sure to change ownership 
of the symlink itself (otherwise it will still be owned by the supervisor 
user).  Was chmod causing issues?  If so we probably want to split the chown 
and chmod portions and only call chmod on things that are not symlinks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to