Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1724#discussion_r82815297
  
    --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
    @@ -485,14 +482,14 @@ int setup_stormdist_dir(const char* local_dir) {
     
           case FTS_DP:        // A directory being visited in post-order
           case FTS_DOT:       // A dot directory
    +      case FTS_SL:        // A symbolic link
    +      case FTS_SLNONE:    // A broken symbolic link
    --- End diff --
    
    I talked with @tgravescs and ran some tests.  It works just fine, and it 
should not be a big deal.  I was a bit worried about the default permissions on 
the symlinks but they are open, and because they are all under a directory that 
should be locked down I am not concerned abut it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to