Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1724#discussion_r82672822
--- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
@@ -414,33 +414,30 @@ static int copy_file(int input, const char*
in_filename,
return 0;
}
-int setup_stormdist(FTSENT* entry, uid_t euser) {
+static int setup_permissions(FTSENT* entry, uid_t euser, int user_write) {
if (lchown(entry->fts_path, euser, launcher_gid) != 0) {
- fprintf(ERRORFILE, "Failure to exec app initialization process - %s\n",
- strerror(errno));
+ fprintf(ERRORFILE, "Failure to exec app initialization process - %s,
fts_path=%s\n",
+ strerror(errno), entry->fts_path);
return -1;
}
mode_t mode = entry->fts_statp->st_mode;
- mode_t new_mode = (mode & (S_IRWXU)) | S_IRGRP | S_IWGRP;
- if ((mode & S_IXUSR) == S_IXUSR) {
- new_mode = new_mode | S_IXGRP;
+ mode_t new_mode = (mode & (S_IRUSR | S_IXUSR)) | S_IRGRP | S_IWGRP;
+ if (user_write) {
+ new_mode = new_mode | S_IWUSR;
--- End diff --
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
