Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1825#discussion_r92845054
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -200,16 +215,22 @@ private void setAcked(TopicPartition tp, long
fetchOffset) {
@Override
public void nextTuple() {
if (initialized) {
- if (commit()) {
- commitOffsetsForAckedTuples();
- }
+ try {
+ refreshPartitionIfNeeded();
- if (poll()) {
- setWaitingToEmit(pollKafkaBroker());
- }
+ if (commit()) {
+ commitOffsetsForAckedTuples();
+ }
- if (waitingToEmit()) {
- emit();
+ if (poll()) {
+ setWaitingToEmit(pollKafkaBroker());
+ }
+
+ if (waitingToEmit()) {
+ emit();
+ }
+ } catch (Exception e) {
--- End diff --
Why are you catching this? If the spout encounters some unexpected
exception, we want it to crash I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
