Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1825#discussion_r92845198
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -59,18 +60,24 @@
// Storm
protected SpoutOutputCollector collector;
+ protected int thisTaskIndex;
+ protected int taskCount;
// Kafka
private final KafkaSpoutConfig<K, V> kafkaSpoutConfig;
private transient KafkaConsumer<K, V> kafkaConsumer;
private transient boolean consumerAutoCommitMode;
+
// Bookkeeping
private transient int maxRetries; //
Max number of times a tuple is retried
private transient FirstPollOffsetStrategy firstPollOffsetStrategy; //
Strategy to determine the fetch offset of the first realized by the spout upon
activation
private transient KafkaSpoutRetryService retryService; //
Class that has the logic to handle tuple failure
private transient Timer commitTimer; //
timer == null for auto commit mode
+ private transient Timer partitionRefreshTimer; //
partitionRefreshTime != null if in manual partition assign model
+ private transient boolean manualPartitionAssignment;
--- End diff --
Nit: Rename to manualPartitionAssignmentEnabled here and in KafkaSpoutConfig
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
