Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1825#discussion_r92851175
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java
---
@@ -0,0 +1,21 @@
+package org.apache.storm.kafka.spout;
+
+import org.apache.kafka.common.TopicPartition;
+
+import java.util.Comparator;
+
+/**
+ * Created by liurenjie on 12/7/16.
+ */
+public enum TopicPartitionComparator implements Comparator<TopicPartition>
{
--- End diff --
Nit: I don't think there's anything wrong with making this an enum, but it
seems conceptually weird to me. Why not just make this a regular class, and
then make the field for it in the spout static?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
