Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1835#discussion_r93108849
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaPartitionReader.java
 ---
    @@ -0,0 +1,10 @@
    +package org.apache.storm.kafka.spout;
    +
    +import org.apache.kafka.clients.consumer.KafkaConsumer;
    +import org.apache.kafka.common.TopicPartition;
    +
    +import java.util.List;
    +
    +public interface KafkaPartitionReader {
    --- End diff --
    
    Nit: Some of these classes could probably go in the internal package, or a 
new subpackage of the internal package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to