Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1835#discussion_r93105747
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -120,6 +124,8 @@ public void open(Map conf, TopologyContext context, 
SpoutOutputCollector collect
                 commitTimer = new Timer(500, 
kafkaSpoutConfig.getOffsetsCommitPeriodMs(), TimeUnit.MILLISECONDS);
             }
     
    +        // Manual partition assignment
    --- End diff --
    
    This doesn't seem like it belongs here anymore


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to