Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r99045714
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutBatchMetadata.java
---
@@ -74,8 +74,8 @@ public TopicPartition getTopicPartition() {
@Override
public String toString() {
- return "KafkaTridentSpoutBatchMetadata{" +
- "topicPartition=" + topicPartition +
+ return super.toString() +
--- End diff --
All this is doing is that the method `toString()` instead of printing
`KafkaTridentSpoutBatchMetadata` it will print
`org.apache.storm.kafka.spout.trident.KafkaTridentSpoutBatchMetadata@6b74f986`.
This was useful while I was debugging and writing the code because the code is
multi threaded for multiple executors, and I needed to see which object
instance (e.g `@6b74f986`) was being passed around. I can revert it back, but
for me there was benefit in having it like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
