Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r99046243
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutTopicPartition.java
---
@@ -43,7 +43,7 @@ public TopicPartition getTopicPartition() {
@Override
public String getId() {
- return topicPartition.topic() + "/" + topicPartition.partition();
+ return topicPartition.topic() + "_" + topicPartition.partition();
--- End diff --
so which one do you think it should be? This is new code that I wrote, so
it should be a matter of choice. Before this change I had **/** but I felt that
there was no need to create a new zookeeper level, hence I changed it to **_**.
**_** is what exists in the old kafka consumer code. Please take a look at
method `org.apache.storm.kafka.Partition#getId()` and let me know which one we
should go with. Currently the code works using either **/** or **_**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
