Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r99056000
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutTopicPartition.java
---
@@ -43,7 +43,7 @@ public TopicPartition getTopicPartition() {
@Override
public String getId() {
- return topicPartition.topic() + "/" + topicPartition.partition();
+ return topicPartition.topic() + "_" + topicPartition.partition();
--- End diff --
Yes it will work if no one is willing to extract the information via
parsing the return value. OK to leave as it is, but if possible I'd like to
avoid the possible confusing case.
If you're worrying about creating redundant znode because of '/', how about
choosing the character which is not legal char for kafka topic but legal char
for znode name, for example, `@`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
