Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/1957#discussion_r102632179
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java ---
@@ -163,12 +164,19 @@ public HdfsSpout setClocksInSync(boolean
clocksInSync) {
return this;
}
-
+ /**
+ * @deprecated use {@link #setIgnoreSuffix(List)} instead.
+ */
public HdfsSpout setIgnoreSuffix(String ignoreSuffix) {
--- End diff --
No needed to deprecate old method and add new one. You just extend the
existing method to accept a space separate list of file extensions. That would
preserve compatibility and extend it at the same time. conversion to an array
can be done internally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
