Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/1957#discussion_r103149784
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java ---
@@ -447,7 +449,12 @@ public void open(Map conf, TopologyContext context,
SpoutOutputCollector collect
// -- ignore file names config
if ( conf.containsKey(Configs.IGNORE_SUFFIX) ) {
- this.ignoreSuffix = conf.get(Configs.IGNORE_SUFFIX).toString();
+ ignoreSuffixes =
Arrays.asList(conf.get(Configs.IGNORE_SUFFIX).toString().split(","));
--- End diff --
This wont handle inputs like: ".ignore1, .ignore2 ,.ignore3" where user
may put one or more spaces before/after the comma. We should allow for that.
Also would be nice to trim off any spaces at the start and end of the entire
string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
