Github user roshannaik commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1957#discussion_r103150479
  
    --- Diff: external/storm-hdfs/README.md ---
    @@ -547,7 +548,7 @@ Only methods mentioned in **bold** are required.
     | **.setArchiveDir()**       |~~hdfsspout.archive.dir~~             |      
       | After a file is processed completely it will be moved to this HDFS 
directory. If this directory does not exist it will be created. E.g. /data/done|
     | **.setBadFilesDir()**      |~~hdfsspout.badfiles.dir~~            |      
       | if there is an error parsing a file's contents, the file is moved to 
this location.  If this directory does not exist it will be created. E.g. 
/data/badfiles  |
     | .setLockDir()              |~~hdfsspout.lock.dir~~                | 
'.lock' subdirectory under hdfsspout.source.dir | Dir in which lock files will 
be created. Concurrent HDFS spout instances synchronize using *lock* files. 
Before processing a file the spout instance creates a lock file in this 
directory with same name as input file and deletes this lock file after 
processing the file. Spouts also periodically makes a note of their progress 
(wrt reading the input file) in the lock file so that another spout instance 
can resume progress on the same file if the spout dies for any reason.|
    -| .setIgnoreSuffix()         |~~hdfsspout.ignore.suffix~~           |   
.ignore   | File names with this suffix in the in the hdfsspout.source.dir 
location will not be processed|
    +| .setIgnoreSuffix()         |~~hdfsspout.ignore.suffix~~           |   
.ignore   | You can provide comma separated suffixes. File names with this 
suffixes in the hdfsspout.source.dir location will not be processed|
    --- End diff --
    
    Suggest rephrasing the description to
     "Comma separated list of file name suffixes. File with matching suffixes 
in the hdfsspout.source.dir location will not be processed"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to