Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2005#discussion_r106340804
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
    @@ -231,6 +231,18 @@ public void deleteBlob(String key, Subject who) throws 
AuthorizationException, K
         }
     
         @Override
    +    public void clearRemovedBlob(String key) throws AuthorizationException 
{
    +        validateKey(key);
    +        // not pulling recent change and checking ACL
    --- End diff --
    
    if you handle this in deleteBlob itself, we don't need to add new api to 
blobstore. i.e. if getStoredBlobMeta throws KeyNotFoundException, just log it 
and skip the ACL check and proceed with deleting the keys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to