Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106342906
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -231,6 +231,18 @@ public void deleteBlob(String key, Subject who) throws
AuthorizationException, K
}
@Override
+ public void clearRemovedBlob(String key) throws AuthorizationException
{
+ validateKey(key);
+ // not pulling recent change and checking ACL
--- End diff --
@arunmahadevan
Yes I was thinking about that way but over-thought about false-positive
(when ZK is down, throwing Exception, etc). KeyNotFoundException clearly states
that ZK is accessible and key is not exist so no false-positive. Thanks I'll
address this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
