Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130425918
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -21,15 +21,10 @@
import static
org.apache.storm.kafka.spout.KafkaSpoutConfig.FirstPollOffsetStrategy.EARLIEST;
import org.apache.kafka.clients.consumer.ConsumerConfig;
--- End diff --
I would call package where this class lives `config.builder` instead of
`builders`, which is a bit misleading since this is really a configuration
class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
