Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2243#discussion_r130435817
  
    --- Diff: examples/storm-kafka-client-examples/pom.xml ---
    @@ -42,7 +42,9 @@
                 <groupId>org.apache.storm</groupId>
                 <artifactId>storm-kafka</artifactId>
                 <version>${project.version}</version>
    +            <!-- You can reduce jar size by uncommenting this and 
providing the dependencies manually. See the README for details.
                 <scope>${provided.scope}</scope>
    --- End diff --
    
    Yes, I somehow missed the dollar. I'll try reverting this and update the 
readme to set the scope to compile


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to