Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2243#discussion_r130419415
  
    --- Diff: examples/storm-kafka-client-examples/pom.xml ---
    @@ -73,19 +75,27 @@
                 <groupId>org.apache.storm</groupId>
                 <artifactId>storm-kafka-client</artifactId>
                 <version>${project.version}</version>
    +            <!-- You can reduce jar size by uncommenting this and 
providing the dependencies manually. See the README for details.
                 <scope>${provided.scope}</scope>
    --- End diff --
    
    Isn't the goal of ${provided.scope} to handle the proper scope according to 
the profile, e.g. just like it is done with the Intellij profile. I am not 
quite following why the user has to comment/uncomment the scope configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to