Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2326#discussion_r139424403
  
    --- Diff: storm-client/src/jvm/org/apache/storm/Constants.java ---
    @@ -30,7 +30,7 @@
         public static final List<Long> SYSTEM_EXECUTOR_ID = Arrays.asList(-1L, 
-1L);
         public static final String SYSTEM_COMPONENT_ID = "__system";
         public static final String SYSTEM_TICK_STREAM_ID = "__tick";
    -    public static final String METRICS_COMPONENT_ID_PREFIX = "__metrics";
    +    public static final String METRICS_COMPONENT_ID_PREFIX = "__metrics_";
    --- End diff --
    
    This is a minor change, but it might impact some people.  We probably want 
to just put this into 2.x for now.  If we really want it in 1.x we can decide 
how much of an impact it is (probably minor, but I want to see what others 
thing about it).


---

Reply via email to