Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2326#discussion_r139427249
  
    --- Diff: storm-client/src/jvm/org/apache/storm/Constants.java ---
    @@ -30,7 +30,7 @@
         public static final List<Long> SYSTEM_EXECUTOR_ID = Arrays.asList(-1L, 
-1L);
         public static final String SYSTEM_COMPONENT_ID = "__system";
         public static final String SYSTEM_TICK_STREAM_ID = "__tick";
    -    public static final String METRICS_COMPONENT_ID_PREFIX = "__metrics";
    +    public static final String METRICS_COMPONENT_ID_PREFIX = "__metrics_";
    --- End diff --
    
    Yea... But I made this change because 
https://github.com/apache/storm/blob/master/docs/Metrics.md says, 
    ```
    The parallelism for each Bolt is set to parallelism.hint and component id 
for that Bolt is set to __metrics_<metrics consumer class name>
    ```
    



---

Reply via email to