Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2326#discussion_r139429698
--- Diff: storm-client/src/jvm/org/apache/storm/Constants.java ---
@@ -30,7 +30,7 @@
public static final List<Long> SYSTEM_EXECUTOR_ID = Arrays.asList(-1L,
-1L);
public static final String SYSTEM_COMPONENT_ID = "__system";
public static final String SYSTEM_TICK_STREAM_ID = "__tick";
- public static final String METRICS_COMPONENT_ID_PREFIX = "__metrics";
+ public static final String METRICS_COMPONENT_ID_PREFIX = "__metrics_";
--- End diff --
That is fine, I think this is a really good fix. I am just saying that it
might make it difficult for someone to find say the LoggingMetricsConsumer in
an automated way, and so if we do make this change in 1.x we should do it
thoughtfully.
---
