Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2366#discussion_r143826667
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
    @@ -20,14 +20,20 @@
     
     import com.google.common.annotations.VisibleForTesting;
     import java.io.Serializable;
    -import java.util.Arrays;
    -import java.util.HashMap;
    -import java.util.List;
    -import java.util.Map;
    -import java.util.Random;
    +import java.util.*;
    --- End diff --
    
    We avoid .* imports, it is against the checkstyle guidelines we have.


---

Reply via email to