Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2366#discussion_r143829089
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -50,10 +61,28 @@
volatile int[] choices;
private volatile int[] prepareChoices;
private AtomicInteger current;
+ private AtomicReference<Scope> currentScopeRef;
--- End diff --
I don't think this needs to be atomic. Only `chooseTasks` needs to be
thread safe. All the others are called from a single thread, and we can put a
lock around if we really want to.
---
