Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2366#discussion_r143828158
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/task/WorkerTopologyContext.java ---
    @@ -34,6 +36,8 @@
         private String _pidDir;
         Map<String, Object> _userResources;
         Map<String, Object> _defaultResources;
    +    private AtomicReference<Map<Integer, NodeInfo>> _taskToNodePort;
    +    private String _assignmentId;
    --- End diff --
    
    Could we avoid adding in new member variables with _ as the first 
character.  This is against the new guidelines.


---

Reply via email to