Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152701420
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -147,21 +153,52 @@ protected void
issueMapCallback(ConcurrentHashMap<String, Runnable> callbackConc
@Override
public List<String> assignments(Runnable callback) {
+ //deprecated
if (callback != null) {
assignmentsCallback.set(callback);
}
- return stateStorage.get_children(ClusterUtils.ASSIGNMENTS_SUBTREE,
callback != null);
+ return this.backend.assignments();
}
@Override
public Assignment assignmentInfo(String stormId, Runnable callback) {
+ //deprecated
+ if (callback != null) {
+ assignmentInfoCallback.put(stormId, callback);
+ }
+ return this.backend.getAssignment(stormId);
+ }
+
+ @Override
+ public Assignment remoteAssignmentInfo(String stormId, Runnable
callback) {
+ //deprecated
if (callback != null) {
assignmentInfoCallback.put(stormId, callback);
}
byte[] serialized =
stateStorage.get_data(ClusterUtils.assignmentPath(stormId), callback != null);
return ClusterUtils.maybeDeserialize(serialized, Assignment.class);
}
+ @Override
+ public Map<String, Assignment> assignmentsInfo() {
+ return this.backend.assignmentsInfo();
+ }
+
+ @Override
+ public void syncRemoteAssignments(Map<String, byte[]> remote) {
+ if (null != remote) {
+ this.backend.syncRemoteAssignments(remote);
+ } else {
+ Map<String, byte[]> tmp = new HashMap<>();
+ List<String> stormIDS =
this.stateStorage.get_children(ClusterUtils.ASSIGNMENTS_SUBTREE, false);
--- End diff --
`stormIDS` -> `stormIds` due to checkstyle, `stormID` -> `stormId` as well
---
