Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r152698363
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
    @@ -147,21 +153,52 @@ protected void 
issueMapCallback(ConcurrentHashMap<String, Runnable> callbackConc
     
         @Override
         public List<String> assignments(Runnable callback) {
    +        //deprecated
    --- End diff --
    
    What we would want to deprecate? If we want to deprecate kind of public 
API, we should announce it to users (marking deprecated annotation, release 
note, etc) or if it is Storm internal, we could just remove it.


---

Reply via email to