Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703031
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -382,6 +374,33 @@ public void establishLogSettingCallback() {
workerState.stormClusterState.topologyLogConfig(topologyId,
this::checkLogConfigChanged);
}
+ /**
+ * Send a heartbeat to local supervisor first to check if supervisor
is ok for heartbeating.
+ */
+ private void heartbeatToMasterIfLocalbeatFail(LSWorkerHeartbeat
lsWorkerHeartbeat) {
--- End diff --
Now we're heartbeating to Supervisor directly and also fail back to Nimbus.
Looks like local state and supervisor heartbeat are kind of redundant. (Not
sure how it works together so please explain a bit if we need both.)
---
