Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2433
@HeartSaVioR :
> By the way, I was not aware of the discussion in storm-mesos, so don't
know which works should be done in Storm side, and how these are coupled with
"this issue". Maybe better to only pointing out relevant things, and discuss in
dev. mailing list if necessary for things out of topic.
I think you're misinterpreting [Jessica's
comments](https://github.com/apache/storm/pull/2433#issuecomment-357140893).
She wasn't trying to bog down this discussion with an attempt to resolve the
other breakages of storm-on-mesos, I believe she was just providing some
context to Bobby's early
statement](https://github.com/apache/storm/pull/2433#issuecomment-356661822)
about storm-on-mesos being broken a few times by changes like this in
storm-core. Furthermore, I believe she was also clarifying that storm-on-mesos
is currently *totally* broken (as explained in the context she provided) in the
1.1+ branches, so this proposed change technically is not *breaking*
storm-on-mesos, since it's already broken. Our goal is simply to prevent even
more breaking changes.
> As far as I understand in your comment, only concern with this issue is
specifying Supervisor's thrift port, which shouldn't be random in range but
just using specified port. If I understand correctly, the patch already does
that (via configuration), and storm-mesos could launch Supervisor instance with
overriding supervisor thrift port. Makes sense?
That has potential to work -- can you please clarify something though? Is
it possible to specify this setting (`supervisor.thrift.port`) as a CLI
parameter to the supervisor as it is launched? If that works then awesome,
that means the requirement Jessica outlined is already satisfied since we can
simply specify that setting when we launch each supervisor. However, if the
option instead must be in the storm configuration yaml file, then it is
insufficient. That is because storm-on-mesos *must* be able to have different
ports for every supervisor, but every supervisor shares the same config file in
storm-on-mesos.
---
