Github user ptgoetz commented on the issue:

    https://github.com/apache/storm/pull/2550
  
    +1 successfully built for me and all tests passed.
    
    As far as squashing commits my opinion has always been if we do squash, it 
should be done when merging. There are a lot of cases where separate commits 
make review easier (e.g. separating pure whitespace changes). If commits are 
squashed during review, you have to re-read all the changes.


---

Reply via email to