Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2550
@erikdw @hmcl @ptgoetz
First of all, I need to make this clear: I'm not claiming that this PR
should be changed. I'm OK to merge this in as it is, and I'll do it once 24hrs
policy is met.
What we want to discuss is the standard rule of Storm, hence it should not
be resolved in offline discussion, but discussion thread in dev list should be
initiated and discussion should take place in there. Standard rule should not
be brought from decision among part of us.
While discussing we need to consider both: 1. the unit of commits 2.
title/body of commit. Without having standard rule, everyone think differently
about twos, contributors and even PMCs. Letting contributors handle any of two
would fail because of that, and if we have standard rule, it is normally the
thing to be automated which everyone is not bothered to handle it manually.
Please take a look at below commits:
https://github.com/apache/spark/commit/30295bf5a6754d0ae43334f7bf00e7a29ed0f1af
https://github.com/apache/zeppelin/commit/c6b73beae71f79b48d834dc751182ec45d244d69
above two projects are having template of PR, and use it for composing body
of commit, which will guarantee commit title/body to conform to their standard
rule. We may bother with filling the template, that's a possible disadvantage.
and other commits:
https://github.com/apache/kafka/commit/7c97b239a5261cf030984f71427287196e657d95
above project don't require filling template but body of PR is taken to
commit body with additional information.
https://github.com/apache/hadoop/commit/f491f717e9ee6b75ad5cfca48da9c6297e94a8f7
https://github.com/apache/hbase/commit/3bb8daa60565ec2f7955352e52c2f6379176d8c6
... and more ...
above projects don't require filling template. Maybe commit body is came
from commit of contributor. In this case most of commits are not having body of
commit message.
---
