Github user erikdw commented on the issue:

    https://github.com/apache/storm/pull/2550
  
    @hmcl @HeartSaVioR : perhaps we can take this offline?  (I admit to being 
guilty of starting this discussion in these PRs.)
    
    I am not grasping the actual problems that you encounter that make 
squashing so important.  I have read everything you wrote here and in the other 
thread where we discussed it.  But I still cannot see what *exactly* is the 
problem for you, nor why all these other big projects have gone to this 
information-losing approach.  All commits of a PR *are* bunched together.  They 
can all be referenced as a group in `git revert` or `git cherry-pick`.   Please 
note I do appreciate that you are willing to allow for divergence from a strict 
"squash all the things" standard when it is valuable.
    
    NOTE: I abhor super noisy PRs that merge tons of bug-fixy commits, 
especially since that encourages bad commit messages as people usually quickly 
write "fixed foo" with no details when they are iteratively committing.  So 
it's a bit uncomfortable to find myself defending *not* squashing.


---

Reply via email to